Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to aws sdk v3, switch to npm #51

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Convert to aws sdk v3, switch to npm #51

merged 3 commits into from
Jul 2, 2024

Conversation

xdumaine
Copy link
Contributor

@xdumaine xdumaine commented May 14, 2024 •
edited
Loading

breaking change. I think I'd like to switch to npm also before doing a major version bump

@xdumaine xdumaine requested a review from a team as a code owner May 14, 2024 22:36
@xdumaine xdumaine requested a review from a team as a code owner May 15, 2024 00:24
@socket-security Socket Security
Copy link

socket-security bot commented May 15, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/[email protected] Transitive: environment, filesystem, network, shell +85 7.59 MB aws-sdk-bot
npm/@aws-sdk/[email protected] Transitive: environment, filesystem, network +25 1.38 MB aws-sdk-bot
npm/@jupiterone/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +138 52.1 MB jupiterone-dev
npm/@jupiterone/[email protected] filesystem Transitive: environment, eval, network, shell, unsafe +469 91.3 MB jupiterone-dev
npm/@lifeomic/[email protected] None 0 33.5 kB lifeomicdev
npm/@types/[email protected] Transitive: environment, filesystem, unsafe +42 1.67 MB types
npm/@types/[email protected] None +1 865 kB types
npm/@types/[email protected] None +1 866 kB types
npm/@types/[email protected] None 0 6.67 kB types
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +273 19.4 MB simenb
npm/[email protected] environment, filesystem, shell Transitive: network +29 1 MB remy
npm/[email protected] environment, filesystem, unsafe Transitive: eval, network, shell +147 46.8 MB kul

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@jupiterone/[email protected], npm/@jupiterone/[email protected], npm/@lifeomic/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@xdumaine xdumaine changed the title Convert to aws sdk v3 Convert to aws sdk v3, switch to node May 15, 2024
@xdumaine
Copy link
Contributor Author

xdumaine commented May 15, 2024 •
edited
Loading

🤦🏽 I completely missed #48 but it looks like we did basically the same thing, with a few small differences. @zemberdotnet apologies for the duplication. If you're good with this, want to go with this one since it also includes node upgrade and doesn't require conflict resolution? I pulled in a couple key things from yours that I missed.

@xdumaine xdumaine changed the title Convert to aws sdk v3, switch to node Convert to aws sdk v3, switch to npm May 15, 2024
@xdumaine xdumaine closed this Jun 3, 2024
@bjoepfeiffer bjoepfeiffer reopened this Jul 2, 2024
@boostsecurity-io BoostSecurity.io
Copy link

⚠️  1 New Security Finding

The latest commit contains 1 new security finding.

Findings
Dependency: npm / braces@ 3.0.2

Vulnerability Information
Vulnerability Severity CVSS EPSS Affected
Versions		 Fixed
Versions		 Contains
Malware		 Description
CVE-2024-4068 Critical 7.5 0.04% 3.0.3
 no Uncontrolled resource consumption in braces
Dependency Location
https://github.com/JupiterOne/dynamodb-dao/blob/aa4732bc28e19a33bd139e95ef8e3c5864e2685c/package-lock.json

Not a finding? Ignore it by adding a comment on the line with just the word noboost.

Scanner: boostsecurity - BoostSecurity osv-scanner

@bjoepfeiffer bjoepfeiffer merged commit 8fcc768 into main Jul 2, 2024
10 checks passed
@bjoepfeiffer bjoepfeiffer deleted the aws-sdk-v3 branch July 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoepfeiffer bjoepfeiffer bjoepfeiffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xdumaine @bjoepfeiffer